Preserve backtraces when re-raising errors #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates locations where StandardError instances are rescued and re-raised as VSphereError to preserve the backtrace info of the original errors along with the message. This change makes debugging easier as the backtrace leads to the location where the error originated instead of the rescue block where it was re-raised.
|
Test failures appear to be unrelated, likely fixed by PR #283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates locations where StandardError instances are rescued
and re-raised as VSphereError to preserve the backtrace info of the
original errors along with the message. This change makes debugging
easier as the backtrace leads to the location where the error originated
instead of the rescue block where it was re-raised.