-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from entrypoints to importlib.metadata #792
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 91.54% 91.32% -0.23%
==========================================
Files 17 17
Lines 1621 1636 +15
==========================================
+ Hits 1484 1494 +10
- Misses 137 142 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one build failure looks unrelated result of merging master in. I'll take a look later at it to resolve if you don't get it before me. Thanks for posting the improvement!
d100d5f
to
b41914f
Compare
b41914f
to
30394a4
Compare
@Borda I've corrected the docstring you've pointed out (sorry it took me so long!) |
@@ -20,6 +20,9 @@ include *.toml | |||
|
|||
include .bumpversion.cfg | |||
|
|||
include papermill/tests/fixtures/foo-0.0.1.dist-info/METADATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks strange to be included, is it testing artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a testing file -- we provide just enough wheel metadata in that path to give us one entry point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda any opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that test shall not be distributed, so for testing you can install it with -e
so if shall see all local files too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda It literally caused a GitHub Actions failure when I didn't include it, I'll note.
I'm looking forward to it as it allows me to drop the entrypoints package from Fedora Linux. Is there any plan to merge and release this? |
You might want to remove entrypoints also from the requirements/docs.txt file: papermill/requirements/docs.txt Line 10 in 5384731
|
Since the minimum Python version supported now directly supports querying entry points using the standard library, write a wrapper around to support both upstream APIs, and make use of it, rather than the external entrypoints package.
30394a4
to
762313b
Compare
Since the minimum Python version supported now directly supports querying entry points using the standard library, write a wrapper around to support both upstream APIs, and make use of it, rather than the external entrypoints package.