Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add information about Griot #100

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented May 27, 2024

Description

I noticed that there was no category for Caribbean food, so I created one and added information about Griot .

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 🍴 Add a traditional food
  • 📝 Documentation Update

Related Tickets & Documents

Related to #86

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

CBID2 added 3 commits May 27, 2024 15:56
Signed-off-by: Christine Belzie <[email protected]>
Signed-off-by: Christine Belzie <[email protected]>
Signed-off-by: Christine Belzie <[email protected]>
@CBID2 CBID2 marked this pull request as ready for review May 27, 2024 20:45
@CBID2 CBID2 requested a review from a team May 27, 2024 20:45
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2,

Thank you for this addition! ✨

As I'm not too familiar in which continent Caribbean is located, I googled it. Most resources — I link to some of them below for your reference — say that it's part of North America.

That said, can you please list your addition under North America?

Thanks. 🙂

@CBID2
Copy link
Contributor Author

CBID2 commented May 27, 2024

Hey @CBID2,

Thank you for this addition! ✨

As I'm not too familiar in which continent Caribbean is located, I googled it. Most resources — I link to some of them below for your reference — say that it's part of North America.

That said, can you please list your addition under North America?

Thanks. 🙂

Made the change @adiati98! 😊 You are correct about the Caribbean being apart of North America. Sometimes I forget that. I guess because in the U.S., the Caribbean is not really connected to America. Lol 😆

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2,

I've left a couple of reviews here.

Also, we've merged a PR before yours. So, please resolve the conflicts before we can review your PR. Thanks! ✨

world-traditional-food.md Outdated Show resolved Hide resolved
world-traditional-food.md Outdated Show resolved Hide resolved
@CBID2
Copy link
Contributor Author

CBID2 commented Jun 2, 2024

Hey @adiati98. I made the changes

@CBID2 CBID2 requested a review from adiati98 June 2, 2024 16:40
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2 there are things to fix here.

Also, can you update your branch with the main branch?
We've merged a PR that added Indian Samosa, but I don't see it here.

Thanks! ✨

world-traditional-food.md Outdated Show resolved Hide resolved
world-traditional-food.md Outdated Show resolved Hide resolved
@CBID2
Copy link
Contributor Author

CBID2 commented Jun 2, 2024

@CBID2 there are things to fix here.

Also, can you update your branch with the main branch? We've merged a PR that added Indian Samosa, but I don't see it here.

Thanks! ✨

Hey @adiati98. I made the changes.

@CBID2 CBID2 requested a review from adiati98 June 2, 2024 21:22
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2,

Can you please ask for review once you've addressed all feedback?
I see you quoted my comment, but you haven't addressed something there.

Thanks.

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 3, 2024

Hey @CBID2,

Can you please ask for review once you've addressed all feedback? I see you quoted my comment, but you haven't addressed something there.

Thanks.

Hey @adiati98. I reread your previous feedback. The information for the Samosa is on line 61. For some odd reason, GitHub won’t let me link it here.

@adiati98
Copy link
Member

adiati98 commented Jun 3, 2024

@CBID2, have you tried to pull it locally?

@CBID2
Copy link
Contributor Author

CBID2 commented Jun 3, 2024

@CBID2, have you tried to pull it locally?

Yes @adiati98

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2,

Thanks for the changes! ✨

FYI, I've removed some things as below:

  • The foods that you've added to the Table of Contents in this commit.
  • Duplication of image resource that somehow got added in this commit.

go time gif

@adiati98 adiati98 merged commit 3ba89f3 into open-sauced:main Jun 3, 2024
3 checks passed
@CBID2
Copy link
Contributor Author

CBID2 commented Jun 3, 2024

Yay! Now everybody gets to enjoy the awesomeness of Haitian food @adiati98! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants