-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add information about Griot #100
docs: add information about Griot #100
Conversation
Signed-off-by: Christine Belzie <[email protected]>
Signed-off-by: Christine Belzie <[email protected]>
Signed-off-by: Christine Belzie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CBID2,
Thank you for this addition! ✨
As I'm not too familiar in which continent Caribbean is located, I googled it. Most resources — I link to some of them below for your reference — say that it's part of North America.
- https://en.wikipedia.org/wiki/List_of_sovereign_states_and_dependent_territories_in_North_America
- https://visaguide.world/north-america-caribbean/
- https://www.quora.com/Is-the-Caribbean-a-part-of-North-or-South-America
That said, can you please list your addition under North America?
Thanks. 🙂
Signed-off-by: Christine Belzie <[email protected]>
Made the change @adiati98! 😊 You are correct about the Caribbean being apart of North America. Sometimes I forget that. I guess because in the U.S., the Caribbean is not really connected to America. Lol 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CBID2,
I've left a couple of reviews here.
Also, we've merged a PR before yours. So, please resolve the conflicts before we can review your PR. Thanks! ✨
Hey @adiati98. I made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBID2 there are things to fix here.
Also, can you update your branch with the main
branch?
We've merged a PR that added Indian Samosa, but I don't see it here.
Thanks! ✨
Co-authored-by: Ayu Adiati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CBID2,
Can you please ask for review once you've addressed all feedback?
I see you quoted my comment, but you haven't addressed something there.
Thanks.
Hey @adiati98. I reread your previous feedback. The information for the Samosa is on line 61. For some odd reason, GitHub won’t let me link it here. |
@CBID2, have you tried to pull it locally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CBID2,
Thanks for the changes! ✨
FYI, I've removed some things as below:
- The foods that you've added to the Table of Contents in this commit.
- Duplication of image resource that somehow got added in this commit.
Yay! Now everybody gets to enjoy the awesomeness of Haitian food @adiati98! 😊 |
Description
I noticed that there was no category for Caribbean food, so I created one and added information about Griot .
What type of PR is this? (check all applicable)
Related Tickets & Documents
Related to #86
Added to documentation?
[optional] What GIF best describes this PR or how it makes you feel?