Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add chicken adobo to world-traditional-food.md #97

Merged
merged 5 commits into from
May 21, 2024

Conversation

syke9p3
Copy link
Contributor

@syke9p3 syke9p3 commented May 18, 2024

Description

This PR adds a new entry "Philippines: Chicken Adobo" to world-traditional-food.md.

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 🍴 Add a traditional food
  • 📝 Documentation Update

Related Tickets & Documents

Relates to #86

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

@syke9p3 syke9p3 requested a review from a team May 18, 2024 05:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@syke9p3 syke9p3 changed the title Add chicken adobo to world-traditional-food.md feat: Add chicken adobo to world-traditional-food.md May 18, 2024
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @syke9p3,
Thank you for your contribution! ✨

I left small reviews here for you to address.

Please let me know if you have questions or need help. 🙂

world-traditional-food.md Outdated Show resolved Hide resolved
world-traditional-food.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@syke9p3 syke9p3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ms. @adiati98! I am a new contributor and overall new to open-source as well. So this PR serves as my first 'real' contribution aside from adding myself as a contributor to the guestbook repository. Thank you for reviewing my pull request and as per suggestions, I have completed the following:

Summary of changes based on reviews:

  • Changed alt text inside img tag
  • Removed excess lines using the "Commit Suggestions" feature

world-traditional-food.md Outdated Show resolved Hide resolved
world-traditional-food.md Outdated Show resolved Hide resolved
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for your contribution, @syke9p3! ✨

If you haven't, you can join our community Discord and see you there! 🙌🏼

git merge GIF

@adiati98 adiati98 merged commit abbc4bb into open-sauced:main May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants