Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add samosa to world-traditional-food.md #99

Merged
merged 6 commits into from
May 28, 2024
Merged

feat: add samosa to world-traditional-food.md #99

merged 6 commits into from
May 28, 2024

Conversation

chydeepak7
Copy link
Contributor

@chydeepak7 chydeepak7 commented May 27, 2024

Description

This PR adds a food to world-traditional-food.md

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 🍴 Add a traditional food
  • 📝 Documentation Update

Related Tickets & Documents

Relates to #86

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

@chydeepak7 chydeepak7 requested a review from a team May 27, 2024 16:43
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

This reverts commit 154d25f.
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chydeepak7,

Thank you for your contribution! ✨

Folks might want to know why Samosa is delicious. So, I have a suggestion here, that would also benefits others.

Can you add information about:

  • What's the filling of Samosa?
  • What's the sauce(s) that are good to dip Samosa into?

You can google them or look it up at Wikipedia. 🙂

world-traditional-food.md Outdated Show resolved Hide resolved
@chydeepak7 chydeepak7 requested a review from adiati98 May 27, 2024 21:21
@adiati98
Copy link
Member

Hi @chydeepak7,

I'm curious about this (and I believe many others, too!)

Can you add a little bit information about:

  • What's the filling of Samosa?
  • What's the sauce(s) that are good to dip Samosa into?

These would be a great information for folks who wants to know what this food is all about and perhaps even want to try it! ✨

@chydeepak7
Copy link
Contributor Author

Yes, I added

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for letting us know more about Samosa, @chydeepak7! ✨

thank you GIF

@adiati98 adiati98 merged commit ba3029c into open-sauced:main May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants