Update Obans semantic conventions

[joshk]

This also required the removal of messaging_destination_kind() as I couldn't find an equivalent in opentelemetry_semantic_conventions ~> 1.27

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: joshk / name: Josh Kalderimis (6acd4bb, e654f0e, 2ada0a1, d25c174)

[joshk]

@tsloughter, sorry to ask. Would it be possible to get a review on this PR?

[joshk]

Hi @bryannaegele , sorry to ask, would it be possible to get approval for the CI to run for this PR?

[bryannaegele]

Sure. Approving to run. Just took a brief glance (not a review) and there look to be a number of issues still to address with the spec. Please take a pass through the spec to cover your bases.

https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/

[joshk]

Hi @bryannaegele , I've updated the code based on the spec, and adjusted the test suite to match.

Could you please approve the CI run once more?

[joshk]

@bryannaegele sorry, is there anything i can do to help this move forward?

[bryannaegele]

Hey @joshk, it can take a couple of weeks for me to have time to review a PR. From another quick glance, it looks like there's still a fair amount that doesn't match the spec. A simple one is the span names. There are also updates since the original implementation around batching, so create and process may be more appropriate for operations.

If you can read through the spec top to bottom and go through the requirements one at a time, that can help move things forward.

[joshk]

Hey @bryannaegele , I'm sorry to ping you, and I appreciate the guidance.

Hmmm, I went through the spec and thought I had everything up to date. I'll go through everything again. Could you point me to an example of something I haven't implemented correctly? (It would help me see where I'm not reading the spec, if that makes sense)

I'm very happy to contribute further, once I'm getting this right :)

[bryannaegele]

I pointed out span names as one example. My recommendation is open the spec page and view it as a check list going from top to bottom, applying anything that's relevant to how oban works

[aloukissas]

How can I help get this through?

[danschultzer]

I missed this PR, but I have been updating Oban to 1.27 conventions in #436. There's more to it as well, e.g. creation context. Also I want to track everything from Oban with #437 because otherwise you need custom sampler due to all the stray Ecto traces.