OTel Resource Detector for AWS #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
danschultzer
force-pushed
the
otel-resource-detector-aws
branch
2 times, most recently
from
5f30af1 to
83e0e34
Compare
danschultzer
commented
Dec 10, 2024
| @@ -0,0 +1,139 @@ | |||
| -module(otel_resource_aws_ecs). | |||
There was a problem hiding this comment.
The naming convention here follows the naming convention in opentelemetry with otel_resource_app_env and otel_resource_env_var
danschultzer
force-pushed
the
otel-resource-detector-aws
branch
from
83e0e34 to
96bac1d
Compare
danschultzer
commented
Dec 10, 2024
| "tagPrefix": "opentelemetry-resource-detector-aws-v", | ||
| "buildTool": "rebar3", | ||
| "language": "erlang", | ||
| "authorizedUsers": ["danschultzer"] |
There was a problem hiding this comment.
I assume I have to manage the releases for this, but lmk if either of you @bryannaegele @tsloughter should be added here.
|
@bryannaegele @tsloughter can I get a review of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OTel Resource Detector for AWS, with support for ECS.
It's essentially a mirror of the JS version.
Resolves #101