add example for OTLP logging via stdout and k8s #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrille-leclerc
suggested changes
Dec 18, 2024
logging-k8s-stdout-otlp-json/otel-collector-otlpjson-pipeline.png
Outdated
Show resolved
Hide resolved
logging-k8s-stdout-otlp-json/otel-collector-otlpjson-pipeline.png
Outdated
Show resolved
Hide resolved
cyrille-leclerc
approved these changes
Dec 18, 2024
|
@trask can you take a look? |
trask
reviewed
Dec 20, 2024
| exporters: [ otlphttp/metrics ] | ||
| logs/raw_otlpjson: | ||
| receivers: [ filelog/otlp-json-logs ] | ||
| # (i) no need for processors before the otlpjson connector |
Comment on lines
+5
to
+7
| ./build.sh | ||
| k3d cluster create jsonlogging || k3d cluster start jsonlogging | ||
| k3d image import -c jsonlogging dice:1.1-SNAPSHOT |
There was a problem hiding this comment.
since this file already has a dependency on the dice image, does it make sense to just inline the one line here?
|
|
||
| - a Java application that uses the experimental | ||
| [experimental-otlp/stdout](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#in-development-exporter-selection) logs exporter | ||
| - a OTel collector configuration that uses the |
There was a problem hiding this comment.
Suggested change
| - a OTel collector configuration that uses the | |
| - an OpenTelemetry collector configuration that uses the |
Comment on lines
+23
to
+25
| The OTel Collector pipeline: | ||
|
|
||
|  |
There was a problem hiding this comment.
Suggested change
| The OTel Collector pipeline: | |
|  | |
| The OpenTelemetry Collector pipeline: | |
|  |
| repository: grafana/oats | ||
| ref: bc2f08c5e55114234cece216290f1580a75a6032 | ||
| path: oats | ||
| - name: Set up Go |
There was a problem hiding this comment.
(sorry, just a nitpicky preference I have)
Suggested change
| - name: Set up Go | |
| - name: Set up Go |
| with: | ||
| go-version: '1.23' | ||
| cache-dependency-path: oats/go.sum | ||
| - name: Run acceptance tests |
There was a problem hiding this comment.
Suggested change
| - name: Run acceptance tests | |
| - name: Run acceptance tests |
| cache-dependency-path: oats/go.sum | ||
| - name: Run acceptance tests | ||
| run: .github/scripts/run-acceptance-tests.sh | ||
| - name: upload log file |
There was a problem hiding this comment.
Suggested change
| - name: upload log file | |
| - name: upload log file |
| # renovate: datasource=github-releases depName=opentelemetry-java-instrumentation packageName=open-telemetry/opentelemetry-java-instrumentation | ||
| ENV OPENTELEMETRY_JAVA_INSTRUMENTATION_VERSION=v2.10.0 | ||
|
|
||
| ADD build/libs/*SNAPSHOT.jar ./app.jar |
There was a problem hiding this comment.
what do you think about adding the ../gradlew assemble here, and then I think could remove it from (the global) run-acceptance-tests.sh file?
Comment on lines
+38
to
+49
| "customManagers": [ | ||
| { | ||
| "customType": "regex", | ||
| "description": "Update _VERSION variables in Dockerfiles", | ||
| "fileMatch": [ | ||
| "(^|/|\\.)Dockerfile$", | ||
| "(^|/)Dockerfile\\.[^/]*$" | ||
| ], | ||
| "matchStrings": [ | ||
| "# renovate: datasource=(?<datasource>[a-z-]+?)(?: depName=(?<depName>.+?))? packageName=(?<packageName>.+?)(?: versioning=(?<versioning>[a-z-]+?))?\\s(?:ENV|ARG) .+?_VERSION=(?<currentValue>.+?)\\s" | ||
| ] | ||
| } |
There was a problem hiding this comment.
maybe rename to run-oats-tests.sh? (and rename workflow to oats-tests.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates open-telemetry/opentelemetry.io#5754