Convert jaxws tests to java #12509
Merged
Convert jaxws tests to java #12509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Oct 23, 2024
Comment on lines
-20
to
-34
| <xs:element name="hello2Request"> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:element name="name" type="xs:string" form="unqualified"/> | ||
| </xs:sequence> | ||
| </xs:complexType> | ||
| </xs:element> | ||
|
|
||
| <xs:element name="hello2Response"> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:element name="message" type="xs:string" form="unqualified"/> | ||
| </xs:sequence> | ||
| </xs:complexType> | ||
| </xs:element> |
There was a problem hiding this comment.
In jax-ws 2 tests hello request also tests the jaxws-jws-api-1.1 instrumentation while hello2 test is constructed so that the jws api instrumentation does not apply to it. In jax-ws 3 we don't have an instrumentation similar to the jws api instrumentation so we need only 1 test case.
jaydeluca
reviewed
Oct 24, 2024
.../src/main/java/io/opentelemetry/javaagent/instrumentation/jaxws/v2_0/AbstractJaxWs2Test.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/opentelemetry/javaagent/instrumentation/jaxws/v2_0/AbstractJaxWs2Test.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jay DeLuca <[email protected]>
jaydeluca
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7195