Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Common http telemetry builder interface #12869

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

trask
Copy link
Member

@trask trask commented Dec 10, 2024

Built on top of #12858 for now...

I'm not sure if we want/need this, but it is part of what motivated #12858

@zeitlinger do you remember if this has any concrete benefits in our codebase (other than enforcing consistency, which could be a good enough reason)?

If you want to look at it, here's the commit to look at: 0bab846

@trask trask changed the title Common http telemetry builder interface [DRAFT] Common http telemetry builder interface Dec 10, 2024
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Dec 10, 2024
@github-actions github-actions bot requested a review from theletterf December 10, 2024 04:32
@zeitlinger
Copy link
Member

do you remember if this has any concrete benefits in our codebase

  • consistency
  • maybe get rid of the delegation in the telemetry builders (e.g. use inheritance instead) - not sure if this still makes sense after the latest changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants