-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Common http telemetry builder interface #12869
Draft
trask
wants to merge
37
commits into
open-telemetry:main
Choose a base branch
from
trask:common-http-telemetry-builder-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] Common http telemetry builder interface #12869
trask
wants to merge
37
commits into
open-telemetry:main
from
trask:common-http-telemetry-builder-interface
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
Common http telemetry builder interface
[DRAFT] Common http telemetry builder interface
Dec 10, 2024
github-actions
bot
added
the
test native
This label can be applied to PRs to trigger them to run native tests
label
Dec 10, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #12858 for now...
I'm not sure if we want/need this, but it is part of what motivated #12858
@zeitlinger do you remember if this has any concrete benefits in our codebase (other than enforcing consistency, which could be a good enough reason)?
If you want to look at it, here's the commit to look at: 0bab846