Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB-API: db.statement inclusion of sqlcomment as opt-in #3115

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Dec 17, 2024

Description

Supports new, optional kwarg enable_attribute_commenter at DB-API integration to opt into db.statement span attribute inclusion of sqlcomment.

Partially addresses #3107

Is required to update driver-level instrumentors like psycopg2, mysqlclient, etc in this PR: #3121

Type of change

Breaking because db.statement span attribute inclusion of sqlcomment currently always happens if sqlcommenter enabled. It'll be opt-in with this update, so might break for those users relying on the feature introduced in 0.50b0, for instrumentation of any of psycopg2, psycopg, mysqlclient, PyMySQL. Those instrumentors will be updated in this PR: #3121

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • tox -e py312-test-instrumentation-dbapi

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review December 19, 2024 21:27
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner December 19, 2024 21:27
@xrmx
Copy link
Contributor

xrmx commented Dec 23, 2024

@alexmojaki PTAL

Copy link
Contributor

@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants