Improve type hints in opentelemetry.instrumentation.utils
#3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Dec 20, 2024
| @@ -44,9 +44,9 @@ | |||
|
|
|||
|
|
|||
| def extract_attributes_from_object( | |||
| obj: any, attributes: Sequence[str], existing: Dict[str, str] = None | |||
| obj: Any, attributes: Sequence[str], existing: Dict[str, str] | None = None | |||
There was a problem hiding this comment.
This is the most important change. any cannot be used as Any.
Kludex
commented
Dec 20, 2024
| @@ -81,7 +83,7 @@ def http_status_to_status_code( | |||
| return StatusCode.ERROR | |||
|
|
|||
|
|
|||
| def unwrap(obj: Union[object, str], attr: str): | |||
| def unwrap(obj: object, attr: str): | |||
There was a problem hiding this comment.
There's a type of redundancy here, since str is an object.
But on the first line of this function, the type checker is able to infer if it's a str or not.
There was a problem hiding this comment.
The union has been added for humans more than for type checkers
xrmx
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.