-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PeriodicReader with own Thread the default #2403
Merged
cijothomas
merged 14 commits into
open-telemetry:main
from
cijothomas:cijothomas/periodicreader-defaults
Dec 11, 2024
Merged
Make PeriodicReader with own Thread the default #2403
cijothomas
merged 14 commits into
open-telemetry:main
from
cijothomas:cijothomas/periodicreader-defaults
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
Dec 10, 2024
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
=======================================
- Coverage 79.4% 79.2% -0.3%
=======================================
Files 123 123
Lines 21527 21527
=======================================
- Hits 17111 17065 -46
- Misses 4416 4462 +46 ☔ View full report in Codecov by Sentry. |
utpilla
approved these changes
Dec 10, 2024
Merging to make progress, happy to address feedbacks post merger. |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics/PeriodicReader part of #2386
reqwest
client it uses needs tokio runtime. This example is retained as-is, demonstrating that existing functionality can be retained as-is by adding "experimental_metrics_periodicreader_with_async_runtime" feature.