Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding updated doc ruby lambda and environment variables for ruby lib… #4904

Merged
merged 20 commits into from
Aug 3, 2024
Merged

adding updated doc ruby lambda and environment variables for ruby lib… #4904

merged 20 commits into from
Aug 3, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

…rary

Update FaaS doc for released ruby lambda layer
Update Ruby doc for environment variables on instrumentation (related to: open-telemetry/opentelemetry-ruby-contrib#1010)

@xuan-cao-swi xuan-cao-swi requested a review from a team July 29, 2024 16:25
@svrnm svrnm requested a review from a team July 29, 2024 16:39
tiffany76
tiffany76 reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggestions for reworking the libraries page. Let me know if you have any questions. Thanks!

content/en/docs/faas/lambda-auto-instrument.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
@xuan-cao-swi xuan-cao-swi requested a review from tiffany76 July 30, 2024 16:03
tiffany76
tiffany76 reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes. On the right track!

content/en/docs/languages/ruby/libraries.md Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Show resolved Hide resolved
kaylareopelle
kaylareopelle requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the doc update, @xuan-cao-swi! I have a few small nit recommendations

content/en/docs/faas/lambda-auto-instrument.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
content/en/docs/languages/ruby/libraries.md Outdated Show resolved Hide resolved
xuan-cao-swi and others added 10 commits July 31, 2024 13:59
@xuan-cao-swi
Merge branch 'main' into ruby-env-var-lambda
1575309
@xuan-cao-swi @kaylareopelle
Update content/en/docs/faas/lambda-auto-instrument.md
25c8857 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
da32f9f 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
ec5446d 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
7128280 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
2691c1e 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
7efca00 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
fe28b8d 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update content/en/docs/languages/ruby/libraries.md
0285d38 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi
Merge branch 'main' into ruby-env-var-lambda
6111244
@opentelemetrybot opentelemetrybot requested review from a team August 1, 2024 14:22
kaylareopelle
kaylareopelle approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xuan-cao-swi!

tiffany76
tiffany76 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@opentelemetrybot opentelemetrybot requested review from a team August 3, 2024 17:57
@cartermp cartermp merged commit bd78b16 into open-telemetry:main Aug 3, 2024
17 checks passed
@xuan-cao-swi xuan-cao-swi deleted the ruby-env-var-lambda branch August 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@tiffany76 tiffany76 tiffany76 approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
sig:ruby
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuan-cao-swi @cartermp @tiffany76 @kaylareopelle