Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337111: Bad HTML checker for generated documentation #22866

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 23, 2024

Hi all,

This pull request contains a backport of commit ed292318 from the openjdk/jdk repository.

The commit being backported was authored by Nizar Benalla on 23 Dec 2024 and was reviewed by Hannes Wallnöfer.

Thanks!

Note: #22844 needs to be integrated before this change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8337111: Bad HTML checker for generated documentation (Sub-task - P4)
  • JDK-8337113: Bad character checker for generated documentation (Sub-task - P4)
  • JDK-8337116: Internal links checker for generated documentation (Sub-task - P4)
  • JDK-8337114: DocType checker for generated documentation (Sub-task - P4)
  • JDK-8337117: External links checker for generated documentation (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22866/head:pull/22866
$ git checkout pull/22866

Update a local copy of the PR:
$ git checkout pull/22866
$ git pull https://git.openjdk.org/jdk.git pull/22866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22866

View PR using the GUI difftool:
$ git pr show -t 22866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22866.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337111: Bad HTML checker for generated documentation
8337113: Bad character checker for generated documentation
8337116: Internal links checker for generated documentation
8337114: DocType checker for generated documentation
8337117: External links checker for generated documentation

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ed292318a98163b3226aa05d06825b48c3d97dbb 8337111: Bad HTML checker for generated documentation Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla
Copy link
Member Author

/issue add 8346780

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
Adding additional issue to issue list: 8346780: External links checker for generated documentation.

@nizarbenalla
Copy link
Member Author

/issue remove 8346780
/issue add 8337117

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
Removing additional issue from issue list: 8346780.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
Adding additional issue to issue list: 8337117: External links checker for generated documentation.

@nizarbenalla
Copy link
Member Author

/label add javadoc

@openjdk openjdk bot added ready Pull request is ready to be integrated javadoc [email protected] labels Dec 25, 2024
@openjdk
Copy link

openjdk bot commented Dec 25, 2024

@nizarbenalla
The javadoc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 25, 2024

Webrevs

@nizarbenalla
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 30, 2024

Going to push as commit 05c3769.
Since your change was applied there has been 1 commit pushed to the jdk24 branch:

  • ab78b04: 8346667: Doccheck: warning about missing before

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2024
@openjdk openjdk bot closed this Dec 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 30, 2024
@openjdk
Copy link

openjdk bot commented Dec 30, 2024

@nizarbenalla Pushed as commit 05c3769.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants