-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316882: Add NOT_INTERRUPTIBLE OpenOption and use it in ZipFS #22882
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back Technici4n! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@Technici4n The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/csr |
@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request. @Technici4n please create a CSR request for issue JDK-8316882 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
The core issue is that FileChannel is an InterruptibleChannel. We've discussed several times on nio-dev about adding an open option to allow the channel be non-interruptible. None of these discussions concluded satisfactorily. If we do it then most of the work will be implications and FileChannel's specification. It looks like you've missed that part and focused on implementation changes. So I think this PR should be closed, please restart the discussion on nio-dev. |
Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882.
Following discussion in nio-dev a while ago, I have opted to add a new
NOT_INTERRUPTIBLE
open option, supersedingFileChannelImpl#setUninterruptible
.Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22882/head:pull/22882
$ git checkout pull/22882
Update a local copy of the PR:
$ git checkout pull/22882
$ git pull https://git.openjdk.org/jdk.git pull/22882/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22882
View PR using the GUI difftool:
$ git pr show -t 22882
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22882.diff
Using Webrev
Link to Webrev Comment