add FAQs & more detail about Easy-CLA #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ljharb
reviewed
Apr 14, 2020
Co-Authored-By: Jordan Harband <[email protected]>
brianwarner
reviewed
May 11, 2020
README.md
Outdated
| ### Do I have to use a CLA for my project? | ||
| No. Projects that would prefer to use a DCO will be directed to use [probot-dco](https://github.com/probot/dco). The foundation is aware of an issue with the DCO implementation and users of GitHub's GUI; we will have a developed work around for this issue soon. | ||
|
|
||
| All OpenJS Foundations should use either a CLA, DCO, or signed commits as a matter of good IPR hygiene. |
There was a problem hiding this comment.
I need to take a look at this one, as the IP policy does not specifically address signed commits (assuming this means "-S" signed, not "-s" signed). I'll take an action here.
| ### What is the OpenJS Foundation CLA? | ||
| In plain terms, the OpenJS Foundation's CLA says that the contributor 1) is legally able to make the contributions, 2) agrees to contribute to OpenJS Foundation projects in accordance with the licenses in their respective repositories, and 3) understands that their contributions are public. Contributors are responsible for reviewing these licenses and ensuring their contributions are compatible. | ||
|
|
||
| Signing the [OpenJS Foundation CLA](https://openjsf.org/about/the-openjs-foundation-cla/) for a contribution you make to one project also enjoins contributions you make to other OpenJS Foundation projects. |
There was a problem hiding this comment.
Suggested change
| Signing the [OpenJS Foundation CLA](https://openjsf.org/about/the-openjs-foundation-cla/) for a contribution you make to one project also enjoins contributions you make to other OpenJS Foundation projects. | |
| Signing the [approved OpenJS Foundation CLA](https://openjsf.org/about/the-openjs-foundation-cla/) for one project will also cover your contributions to other OpenJS Foundation projects, and you will not need to take further action when contributing to those repos. |
| Signing the [OpenJS Foundation CLA](https://openjsf.org/about/the-openjs-foundation-cla/) for a contribution you make to one project also enjoins contributions you make to other OpenJS Foundation projects. | ||
|
|
||
| ### Who needs to sign the OpenJS Foundation CLA? | ||
| Any committer to OpenJS Foundation projects that use a CLA needs to sign, regardless of whether they submitted the PR. |
There was a problem hiding this comment.
Suggested change
| Any committer to OpenJS Foundation projects that use a CLA needs to sign, regardless of whether they submitted the PR. | |
| Every contributor who has authored a commit in a PR must sign the CLA in order for their code to be merged the first time. |
| Once you have signed it for one OpenJS Foundation project, you will not need to sign it again to contribute to another Foundation project using the CLA. | ||
|
|
||
| ### How does Easy-CLA work? | ||
| You can test the user flow for Easy-CLA by submitting a PR to this repo. When a contributor submits a pull request, Easy-CLA checks to see if that contributor's GitHub account has agreed to the OpenJS Foundation CLA. If it has, the check passes and the PR can be merged. |
There was a problem hiding this comment.
Suggested change
| You can test the user flow for Easy-CLA by submitting a PR to this repo. When a contributor submits a pull request, Easy-CLA checks to see if that contributor's GitHub account has agreed to the OpenJS Foundation CLA. If it has, the check passes and the PR can be merged. | |
| You can test the user flow for Easy-CLA by submitting a PR to this repo. When a contributor submits a pull request, Easy-CLA checks to see if that contributor's GitHub account is associated with a CLA signature, or if their employer has added them to their authorized contributors list. If it has, the check passes and the PR can be merged. |
| If the contributor has not signed the OpenJS Foundation CLA, the bot directs them (and all parties with commits on the PR who have not signed the CLA) to authorize the Easy-CLA app to read their GitHub account data. After authorization, the contributor is taken to the Community Bridge Easy-CLA app. In the app, the contributor must choose whether they are contributing on behalf on an employer or as an individual. | ||
|
|
||
| #### Contributing as an Employee | ||
| If contributing on behalf of an employer, the contributor should select 'Corporate', select their employer from the list, and continue with the instructions. Corporate contributors' commitments are covered under an [Corporate Contributor License Agreement](https://openjsf.org/wp-content/uploads/sites/84/2020/01/OpenJS-Foundation-Corporate-CLA-2019-12-13.pdf). **If your employer is not listed,** follow the instructions to notify your corporate CLA Manager to create an account with the Linux Foundation and add your GitHub username to their list of permitted users. |
There was a problem hiding this comment.
Suggested change
| If contributing on behalf of an employer, the contributor should select 'Corporate', select their employer from the list, and continue with the instructions. Corporate contributors' commitments are covered under an [Corporate Contributor License Agreement](https://openjsf.org/wp-content/uploads/sites/84/2020/01/OpenJS-Foundation-Corporate-CLA-2019-12-13.pdf). **If your employer is not listed,** follow the instructions to notify your corporate CLA Manager to create an account with the Linux Foundation and add your GitHub username to their list of permitted users. | |
| If contributing on behalf of an employer, the contributor should select 'Corporate', select their employer from the list, and continue with the instructions. Corporate contributors' commitments are covered under an [Corporate Contributor License Agreement](https://corporate-cla.openjsf.org). **If your employer is not listed,** follow the instructions to notify your corporate CLA Manager to create an account with the Linux Foundation and add your GitHub username to their list of permitted users. |
|
|
||
| ### What if my employment status changes? | ||
|
|
||
| Your former company's CLA manager will need to remove you from their allowlist as part of your off-boarding from the company. Your next PR will trigger the Easy-CLA tool for signature, and you will need to sign again either as an Individual or as part of your new company. |
There was a problem hiding this comment.
Suggested change
| Your former company's CLA manager will need to remove you from their allowlist as part of your off-boarding from the company. Your next PR will trigger the Easy-CLA tool for signature, and you will need to sign again either as an Individual or as part of your new company. | |
| Your former company's CLA manager will need to remove you from their list of authorized contributors as part of your off-boarding from the company. Your next PR will trigger the Easy-CLA tool for signature, and you will need to sign again either as an Individual or as an employee of your new company. |
README.md
Outdated
| * **Provide a list of permitted bots in advance.** We will make sure these tools are not caught by the Easy-CLA tool. | ||
| * **If you have a lot of contributors, we can help jump start the process for contributions that will be covered under a Corporate CLA.** We can work with you and your maintainer team to make sure that your biggest recurring contributors are not unduly inconvenienced the next time they submit a PR. | ||
| * **It's a good idea to message this upcoming change in advance.** This will let your community know what changes to expect, why, and give them a chance to review the CLA or get their company to sign or update their Corporate CLA. | ||
| * **This is the same tool used by 100s of Linux Foundation projects.** That means _a lot_ of companies have signed the Corporate CLA already, and a lot of your contributors (or would be contributors) are likely covered. |
There was a problem hiding this comment.
Suggested change
| * **This is the same tool used by 100s of Linux Foundation projects.** That means _a lot_ of companies have signed the Corporate CLA already, and a lot of your contributors (or would be contributors) are likely covered. | |
| * **This is the same tool used by 100s of Linux Foundation projects.** That means _a lot_ of companies have signed the Corporate CLA already, and a lot of your contributors (or would be contributors) are likely covered. | |
| * **Your employer can authorize you individually, or can choose to authorize everyone with an email on the company domain.** This is a decision that's made by the company signing the CLA. |
| If contributing on behalf of an employer, the contributor should select 'Corporate', select their employer from the list, and continue with the instructions. Corporate contributors' commitments are covered under an [Corporate Contributor License Agreement](https://openjsf.org/wp-content/uploads/sites/84/2020/01/OpenJS-Foundation-Corporate-CLA-2019-12-13.pdf). **If your employer is not listed,** follow the instructions to notify your corporate CLA Manager to create an account with the Linux Foundation and add your GitHub username to their list of permitted users. | ||
|
|
||
| **If your employer is listed but you are not on the list of permitted users,** you will get a message directing you to check your GitHub settings and/or notify the company CLA Manager that you need to be added to the list of allowed users. | ||
|
|
There was a problem hiding this comment.
Suggested change
| Once you are added to the list of approved contributors, you will be asked to log in one more time to confirm that you are an employee of the organization. This helps verify the correct user was added by the company. | |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.