Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node.js assets #23

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

update node.js assets #23

wants to merge 7 commits into from

Conversation

AugustinMauroy
Copy link
Contributor

@AugustinMauroy AugustinMauroy commented Nov 29, 2024 •
edited
Loading

  • add stacked logo
  • add mastoct
  • add black assets

UlisesGascon
UlisesGascon approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge +1

@rginn
Copy link

rginn commented Dec 2, 2024 •
edited
Loading

-1 These variations break the official logo and brand guidelines. For example, mixing b/w and color, and changing the grayscale. I also don't recommend adding the mascot to this repo because this is the site for official logos.

@ljharb
Copy link
Member

ljharb commented Dec 2, 2024

isn't the mascot official?

@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Dec 3, 2024 •
edited
Loading

Ah I'm embarrassed because I've completed the assets here thanks to the resource on https://nodejs.org/en/about/branding. Could you validate that the resources there are good?

Here my figma with all assets https://www.figma.com/design/WB7x2emfJCSCnFGeU3xLNK/nodejs---assets-tool-box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AugustinMauroy @rginn @ljharb @UlisesGascon