Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-18163] Implement thread-safe autoloading #3078

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

[GR-18163] Implement thread-safe autoloading #3078

wants to merge 19 commits into from

Conversation

graalvmbot
Copy link
Collaborator

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 31, 2023
@eregon eregon mentioned this pull request May 31, 2023
Open
@graalvmbot graalvmbot force-pushed the bd/thread-safe-autoload branch from 898ac0d to 1c42f7e Compare June 9, 2023 13:25
eregon added 8 commits June 12, 2023 13:22
@eregon
Pass the AutoloadConstant to setConstantInternal()
bfa68bf 
* Do not use the RubyConstant#value field to store the path for an autoload,
  it is already stored in the AutoloadConstant.
* Now it is clear the RubyConstant#value is null for an autoload.
@eregon
No need to set the constants for updateAnonymousChildrenModules()
e13ae6c
@eregon
Implement thread-safe autoloading
f718287 
* We stash the value of the constant being autoloaded in AutoloadConstant
  and only publish it once the autoload ends.
* Fixes #2431
  and #3040
@eregon
Copy RubyConstant objects on Module#dup
ac8067b 
* Necessary to pass the cleaned-up spec in this commit.
@eregon
Remember the node which set the unpublishedValue for Module#const_sou…
1351309 
…rce_location
@eregon
Untag pass Kernel#require specs
80eb385
@eregon
Publish an autoload constant only once
3bf93a8
@eregon
Add spec for thread-safe autoload
fb34cc3
@graalvmbot graalvmbot force-pushed the bd/thread-safe-autoload branch from 1c42f7e to a4bc1f8 Compare June 12, 2023 11:30
@graalvmbot graalvmbot force-pushed the bd/thread-safe-autoload branch from a4bc1f8 to 7dceedd Compare June 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graalvmbot @eregon