Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): print real newline when \n is inside template literals #8178

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 29, 2024

No description provided.

@github-actions github-actions bot added A-codegen Area - Code Generation C-enhancement Category - New feature or request labels Dec 29, 2024
Copy link
Member Author

Boshen commented Dec 29, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Dec 29, 2024

Merge activity

  • Dec 29, 3:18 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 29, 7:21 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 29, 7:25 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 12-29-feat_codegen_print_real_newline_when_n_is_inside_template_literals branch from 2a3fe6f to 7354c3d Compare December 29, 2024 12:08
Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #8178 will not alter performance

Comparing 12-29-feat_codegen_print_real_newline_when_n_is_inside_template_literals (ad146bb) with main (75d5f17)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 12-29-feat_codegen_print_real_newline_when_n_is_inside_template_literals branch from 7354c3d to 03210e4 Compare December 29, 2024 12:16
@Boshen Boshen force-pushed the 12-29-feat_codegen_print_real_newline_when_n_is_inside_template_literals branch from 03210e4 to ad146bb Compare December 29, 2024 12:20
@graphite-app graphite-app bot merged commit ad146bb into main Dec 29, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-29-feat_codegen_print_real_newline_when_n_is_inside_template_literals branch December 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant