Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add navbar problem page #405

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lucyleeow
Copy link
Contributor

@lucyleeow lucyleeow commented Feb 28, 2020

closes #400
Adds navbar to the top of problem page

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          99       99           
  Lines        7943     7943           
=======================================
  Hits         7359     7359           
  Misses        584      584

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e587e7...d1201da. Read the comment docs.

@lucyleeow
Copy link
Contributor Author

lucyleeow commented Feb 28, 2020

The navbar in the event.html and problem.html pages are now the same length as the notebook iframe below it (and also the same width across the 2 pages).

Add navbar with 'description' and 'download kit' buttons to problem.html page:

image

Still to add leaderboard button linking to combined leaderboard for all events, with solutions deactivated unless it is the user's own solution.
I will work on this last part once @glemaitre is back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tab challenge leaderboard
1 participant