Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: renames User class and other function argument names #154

Open
wants to merge 2 commits into
base: refactor-user-class
Choose a base branch
from

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 20, 2024

What's New?

  • renames UserAPI class to `User
  • renames user_api.rb to user.rb
  • renames various method kwargs

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 marked this pull request as ready for review December 20, 2024 22:51
@ctran88 ctran88 requested a review from a team December 20, 2024 22:51
@ctran88 ctran88 force-pushed the PSG-5215-remove-deprecated-code branch from f94c25b to 9db8262 Compare December 23, 2024 22:15
@ctran88 ctran88 force-pushed the PSG-5524-update-arg-and-filenames branch from 736b3c8 to 0cd1a00 Compare December 23, 2024 22:41
@ctran88 ctran88 changed the base branch from PSG-5215-remove-deprecated-code to refactor-user-class December 23, 2024 22:41
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant