Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): fix unsafe install script (args passing) #1053

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rustdevbtw
Copy link
Contributor

The unsafe install thing (that was added recently), creates a bit different script as you know.
Well, in that, the args that you pass to the program were being passed as a single argument ("$ARGS"). So, here's the simple one-line solution.

cc @jhheider

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12028820129

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 92.029%

Files with Coverage Reduction New Missed Lines %
src/utils/execve.ts 1 91.11%
Totals Coverage Status
Change from base Build 11988281915: 0.9%
Covered Lines: 1376
Relevant Lines: 1490

💛 - Coveralls

Copy link
Contributor

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell splitting is the worst. Will this work with spaces in arguments, or does the code really need to use an array?

@rustdevbtw
Copy link
Contributor Author

Shell splitting is the worst. Will this work with spaces in arguments, or does the code really need to use an array?

Well, if you pass something like:

pandoc file.md -thtml

Using quotes will make it:

pandoc "file.md -thtml"

So, it wouldn't work.

Without $ARGS quoted:

pandoc file.md -thtml

So, yeah. It'll work with spaces in arguments with this solution, I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants