-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH26: Also pack KuduSync as a .Net Global Tool #27
base: master
Are you sure you want to change the base?
Conversation
@hitchhiker @davidebbo @ankitkumarr @Shazwazza @snobu @ahmelsayed it is great that @devlead has been able to provide this PR to add .Net Global Tool support. Is this something that is desired for this project? I have been using KuduSync for a while now in my build orchestration, and it has been great! Having the ability to run it as a .Net Global Tool really would be the icing on the cake. Thanks! |
Apologies @suwatch I didn’t mean to miss you from the above. |
@hitchhiker @davidebbo @ankitkumarr @Shazwazza @snobu @ahmelsayed @suwatch I wanted to follow up with this... Is the work in this PR something that you are interested in proceeding with? I understand that you might not be in a position to review it right now, but even a comment here to provide some input would be appreciated. Thanks! |
Sorry all I haven't used this project specifically for years so don't think I can be much help at the moment. All the best! |
@shpraka @suwatch @AustinWise I notice that you have recently made changes to this repository. Can any of you provide guidance as to whether this PR is something that you would like to see merged in? Thanks! |
This is a proposal on how to address #26, aware a lot is going on in this PR, but project needed some love to build as a .NET Global Tool using .NET Core CLI.
Happy to refactor or spread across multiple PRs if you like, have devided PR in a few commits.
Things added in this PR
nuget.exe
andnuspec
todotnet pack
andcsproj
.CommandLineParser
to latest which is compatible with .NET Core (2.8.0)System.IO.Abstraction
to latest compatible with .NET 4.5 (7.1.10) and latest compatible with .NET Core (12.0.4)CommandLineParser
andSystem.IO.Abstraction
had breaking changes going back serveral versions.CommandLineParser
now autmatically prints usage soKuduSyncOptions.GetUsage
no longer needed.mocha
was used.Update 2021 Jan 13th
Updare 2023 Jul 26th