API: Array API support - Part 1 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 90.99% 91.50% +0.51%
==========================================
Files 20 20
Lines 3376 3497 +121
==========================================
+ Hits 3072 3200 +128
+ Misses 304 297 -7 |
mtsokol
force-pushed
the
array-api-support
branch
from
064ee90 to
23f997d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import warnings | ||
|
|
||
| import numpy as np | ||
| import numba |
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note
|
|
||
| import numpy as np | ||
| import numba | ||
| import scipy.sparse |
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note
Comment on lines
+2114
to
+2116
| def asarray( | ||
| obj, /, *, dtype=None, format="coo", backend="pydata", device=None, copy=False | ||
| ): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
mtsokol
force-pushed
the
array-api-support
branch
from
23f997d to
1d6943c
Compare
hameerabbasi
approved these changes
Dec 21, 2023
|
Thanks, @mtsokol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hameerabbasi,
This PR adds some improvements for Array API support: new functions and additional imports from the NumPy in the main namespace.