-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install pyyaml via apt #134
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather not; per this comment this would break the action for windows, and the problem seems to be an upstream issue -- better that users avoid specifying the problematic runner. I recommend to close this PR.
I'm totally on your page to not break this action for non-ubuntu runners. But I think it's a bit unsatisfactory to implicitly pin the upper bound of the OS version. We could, for example, ether
I'm on mobile right now and I don't think I'll come back to my PC before tomorrow morning. But I'd be happy to work on this, if you agree that this should be implemented in a more flexible way. Maybe this issue will also be solved by the github devs over here. |
Yes, this is the crux of my argument -- it's not our fault, and if we wait a bit it will go away. I think
Instead of "fixing" it in the action here, we could alternatively make a (temporary) fix in the reusable workflow itself where we explicitly change the default runner from "ubuntu-latest" to a pinned older ubuntu runner. |
When seeing their discussion, I'm not so sure they will fix it soon. |
Another solution would be to use
. |
My top preference would be to leverage the existing |
See title. Somehow, the runner-os complains when trying to use
pip install pyyaml
. So I replaced this byapt install python3-yaml
. See also here