Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parsing dist.version twice in a row #11922

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Avoid parsing dist.version twice in a row #11922

merged 1 commit into from
Apr 10, 2023

Conversation

collinanderson
Copy link
Contributor

dist.version is a property that parses the version string each time, so it's slightly faster to only parse it once.

@collinanderson
Avoid parsing dist.version twice in a row
fc29515 
dist.version is a property that parses the version string each time, so it's slightly faster to only parse it once.
@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 10, 2023
@sbidoul sbidoul merged commit cd7aeb7 into pypa:main Apr 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
@ichard26 ichard26 added the type: performance Commands take too long to run label Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: performance Commands take too long to run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@collinanderson @uranusjr @sbidoul @ichard26