Return file size along with count on cache purge or removal

[charwick]

Fixes #12176

[ichard26]

Why not keep both? It can be helpful to know how many wheels were removed.

You should also use utils.misc.format_size() as reading something like 10,182,123 bytes of files removed is not exactly user friendly...

Perhaps something like this?

        bytes_removed = 0
        for filename in files:
            bytes_removed += os.stat(filename).st_size
            os.unlink(filename)
            logger.verbose("Removed %s", filename)
        logger.info("Files removed: %s (%s)", len(files), format_size(bytes_removed))

[charwick]

Good call on format_size(). I'm fine with it reporting both, though I'm curious when it would ever be useful to know the number of files removed?

[ichard26]

It isn't useful for pip cache purge, yes, but it can helpful when you're trying to remove only a few cached wheels, say with pip cache remove six.

I'll leave this open in case other maintainers have differing opinions, but otherwise, this looks good to me! Thank you!

[ichard26]

This should be updated to note that it's alongside the count and affects both purge and remove.

[ichard26]

Congrats on your first contribution! @charwick