-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tzdata as dev dependency and sync with tox.ini #1159
base: master
Are you sure you want to change the base?
Conversation
@tomasr8 Hi, do you need any additional tests or information before running the workflow tests? |
Not in my power ;) @akx mind enabling the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond the inline note that the dependency should have the same platform marker it had in the tox.ini file (so as to avoid installing it on platforms where it's unnecessary), it would be better to do as I suggested in #1150 (comment), IOW get rid of the duplicated dependency lists altogether.
@akx Thanks for reviewing! I made changes per your feedback. |
Co-authored-by: Tomas R. <[email protected]>
Can we run CI for these changes? |
@akx Would you be able to take a look? Thanks! |
Summary
Related Issue
Closes #1150
Changes Made
Testing Done
Recreated virtual environment and installed the dependencies using:
Test output matches before and after changes
Tested on Windows OS