Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tzdata as dev dependency and sync with tox.ini #1159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wandrew004
Copy link

@wandrew004 wandrew004 commented Dec 5, 2024

Summary

  • This resolves issues with missing dependencies when running tests on Windows

Related Issue

Closes #1150

Changes Made

  • Added tzdata to the dev dependencies in setup.py
  • Updated tox.ini to remove tzdata to make it consistent with setup.py

Testing Done

Recreated virtual environment and installed the dependencies using:

rm -rf venv
python -m venv venv
source venv/bin/activate
pip install -e .[dev]

Test output matches before and after changes
image

Tested on Windows OS

@wandrew004
Copy link
Author

@tomasr8 Hi, do you need any additional tests or information before running the workflow tests?

@tomasr8
Copy link
Member

tomasr8 commented Dec 9, 2024

Not in my power ;) @akx mind enabling the workflow?

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline note that the dependency should have the same platform marker it had in the tox.ini file (so as to avoid installing it on platforms where it's unnecessary), it would be better to do as I suggested in #1150 (comment), IOW get rid of the duplicated dependency lists altogether.

setup.py Outdated Show resolved Hide resolved
@akx akx changed the title Add tazdata as dev dependencies and sync with tox.ini Add tzdata as dev dependency and sync with tox.ini Dec 9, 2024
@wandrew004
Copy link
Author

@akx Thanks for reviewing! I made changes per your feedback.

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Tomas R. <[email protected]>
@wandrew004
Copy link
Author

Can we run CI for these changes?

@wandrew004
Copy link
Author

@akx Would you be able to take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup instructions in CONTRIBUTING.md do not install all dependencies
3 participants