-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use constraints file for sdist/wheel build + get version using build.util #3167
base: main
Are you sure you want to change the base?
Conversation
fcbfe33
to
b63587a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18427 18427
Branches 1215 1215
===============================================
Hits 18427 18427 |
If you're going this route already, let's also set |
@@ -40,14 +40,19 @@ jobs: | |||
with: | |||
persist-credentials: false | |||
|
|||
- name: Install build | |||
run: python -Im pip install build -c test-requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would leak into the underlying PEP 517 ephemeral build envs.
run: python -Im pip install build -c test-requirements.txt | |
env: | |
PIP_CONSTRAINT: test-requirements.txt | |
run: python -Im pip install build |
@@ -58,9 +63,6 @@ jobs: | |||
DIST_NAME: ${{ env.dist-name }} | |||
VERSION: ${{ steps.dist-version.outputs.version }} | |||
|
|||
- name: Install build | |||
run: python -Im pip install build | |||
|
|||
- name: Build dists | |||
run: python -Im build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming, you'll do something like pip-compile --only-build-deps --output-file=build-requirements.txt pyproject.toml
:
run: python -Im build | |
env: | |
PIP_CONSTRAINT: build-requirements.txt | |
run: python -Im build |
@@ -41,7 +41,7 @@ python -m pip install -U pip uv -c test-requirements.txt | |||
python -m pip --version | |||
python -m uv --version | |||
|
|||
python -m uv pip install build | |||
python -m uv pip install build -c test-requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also use an env var:
python -m uv pip install build -c test-requirements.txt | |
PIP_CONSTRAINT=test-requirements.txt python -m uv pip install build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I realized that this project doesn't have a combined workflow and so this https://github.com/python-trio/trio/blob/main/.github/workflows/release.yml also needs to be handled similarly.
stuff that I wanted to sneak into the zizmor PR, but decided should be in another PR