Improve handling of aria-controls #3243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aria-controls` attribute should be set only when an element with the specified id is available in the DOM.
The `aria-controls` attribute should be set only when an element with the specified id is available in the DOM.
The `aria-controls` attribute should be set only when an element with the specified id is available in the DOM.
The `aria-controls` attribute should be set only when an element with the specified id is available in the DOM.
The `aria-controls` attribute should be set only when an element with the specified id is available in the DOM.
The `aria-controls` attribute should be set only when an element with the specified id is available in the DOM.
dodomorandi
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
|
Great update! Would love to clear out those unnecessary accessibility errors and make usage cleaner. Looking forward to seeing this land! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix the a11y issues around
aria-controlsbeing used even when components are in the closed state, and the related element is unmounted.I have not been able to create a working test for the
Menucomponent, and I also think that theforceMountattribute does not work very well with this feature (I am only checking the value of theopenstate).Closes #3242