Import guides dark mode highlight.js colors #372
+59
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The current background is _very_ dark * Hovered links appear white * Better contrast on code blocks
Rails guides always have codeblocks themed dark. Might make sense here as well, but this just uses the same colors. Mostly colors are more softer. Comments have better contrast.
zzak
approved these changes
Dec 6, 2024
|
FWIW, I don't currently plan to do anything else. It's just that the colors have been bugging me and the guides already have something that someone else has put thought into. I guess the foundation will give this a proper facelift to bring it inline with guides sometime in the future, whenever that may be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #371, I wasn't sure if that would be accepted.
Rails guides now always have codeblocks themed dark.
Might make sense here as well, but this just uses the same colors.
Since rails guides use scss it wasn't just copy-paste but nothing multiline cursor editing can't handle.
Mostly colors are more softer. Comments have better contrast.
Before:
https://deploy-preview-371--sdoc.netlify.app/classes/activesupport/cache
After:
https://deploy-preview-372--sdoc.netlify.app/classes/activesupport/cache