-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove versioneer and setup.cfg references in docs, update rapids-dependency-file-generator #1509
remove versioneer and setup.cfg references in docs, update rapids-dependency-file-generator #1509
Conversation
…endency-file-generator
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
@@ -72,16 +72,12 @@ Specifically, cuSpatial uses the following tools: | |||
- [`isort`](https://pycqa.github.io/isort/) ensures imports are sorted consistently. | |||
|
|||
Linter config data is stored in a number of files. cuSpatial generally uses `pyproject.toml` over | |||
`setup.cfg` and avoids project-specific files (e.g. `setup.cfg` > `python/cudf/setup.cfg`). However, | |||
differences between tools and the different packages in the repo result in the following caveats: | |||
`setup.cfg` and prefers root-level files to project-specific files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine with removing the reference to setup.cfg
altogether.
Also we need to do a pass through RAPIDS repos and get rid of flake8/black/isort in favor of ruff. There is no technical reason why we are still using flake8, we just haven't switched over to ruff in several RAPIDS repos. (The only minor caveat I am aware of is that isort supports Cython files while ruff's isort does not, but we decided not to worry about that.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, pushed e50c506 removing this last reference to it.
And put up a tracking issue for the ruff
migration: rapidsai/build-planning#130
/merge |
Description
Removes references to
setup.cfg
andversioneer
in the contributing docs...cuspatial
no longer uses either of these.Also updates
rapids-dependency-file-generator
to its latest version (v1.17.0) and removes an unused YAML anchor independencies.yaml
.Checklist