Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fire OS compatibility #1438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mosesroth
Copy link

@mosesroth mosesroth commented Dec 19, 2024

πŸ“ Why & how

This PR adds Fire OS compatibility as an option to the directory and includes 45 libraries that have been tested and confirmed compatible with Fire OS.

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

@mosesroth mosesroth marked this pull request as ready for review December 19, 2024 19:50
@mosesroth mosesroth changed the title Fireos compat Add Fire OS compatibility Dec 19, 2024
@mosesroth
Copy link
Author

Co-authored with @chris-trag and @giolaq

@chris-trag
Copy link

Screenshots showing the Fire OS platform filter / checkbox:

image

image

Thanks!

Copy link
Author

@mosesroth mosesroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inserted ⏎ per warning

@Simek
Copy link
Member

Simek commented Dec 27, 2024

Hey @mosesroth, thanks for working on this addition! I would like to ask few questions before we can proceed.

About which Fire OS we are talking about, is it the Android TV fork?

Or this is about the new, proprietary Linux-based OS announced earlier this year?

@mosesroth
Copy link
Author

Hi @Simek , yes Fire OS is the Android fork mentioned on the doc you linked, which is what we tested on.

Thanks,

Moses

@Simek
Copy link
Member

Simek commented Dec 27, 2024

Thanks for the clarification Moses! πŸ‘

We were discussing this addition internally, and with react-native-tvos maintainer, and in case of the Android fork we lean into thinking that the separation (definition of FireOS as a separate platform) is not needed.

AFAIK when it comes to Android TV, all libraries marked with Android or tvOS support should be working fine on Android TV (so also on Fire OS) devices, since most of the code is shared with Android mobile platform. You can check the RN tvOS readme for a bit more details on that topic:

This is also a take that the Fire OS page I have linked previously stand by:

Fire OS is a fork of Android, so if your app runs on Android, it will most likely run on Amazon's Fire devices too.

If there are something that we miss, any concerns about compatibility or important differences between regular Android TV and Fire OS please let us know. We are happy to learn more about TV apps ecosystem, and work on clarifying the state of libraries support for different TV targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants