Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 47 Libraries to directory 🚀 #289

Merged
merged 9 commits into from
May 9, 2020

Conversation

@vercel
Copy link

vercel bot commented May 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

@mitulsavani
Copy link
Contributor Author

mitulsavani commented May 8, 2020

Hi @brentvatne Please let me know if everything looks good to you. If so, then I will go ahead and submit a few other PR next week in the similar way.

@mitulsavani
Copy link
Contributor Author

mitulsavani commented May 8, 2020

I appreciate you for your time and efforts in reviewing the PR. I will work on your feedback soon! 🙏

Initially, I was under the impression that I would have to change the unmaintained tag as true if the repo is officially marked as deprecated. I will definitely watch out for that.

I was wondering if you please tell me by looking at what signal do we decide and change the expo tag to true?

Thanks once again

@brentvatne
Copy link
Contributor

hey @mitulsavani! it can be a bit tricky to determine if it's compatible with expo client, i tried to help explain that here: https://docs.expo.io/workflow/using-libraries/#determining-third-party-library-compatibility. if you're not sure, you can leave it blank and i will fill it in the pull requests, but an effort to determine whether it is or not is definitely much appreciated!

@brentvatne brentvatne merged commit be858bb into react-native-community:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants