Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only include lib in $LOAD_PATH if not included yet #610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pvdb
Copy link
Contributor

@pvdb pvdb commented Dec 20, 2024

When running the rake tests using bundle exec rake test, the lib directory is added to $LOAD_PATH twice, once by the Rakefile, and again by test_helper.rb ... the change in this PR only adds it if it isn't present already, following the idiom that's already used by the Rakefile:

lib = File.expand_path("../lib", __FILE__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

Consistency FTW ... thanks @hsbt ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant