Reenable JRuby #1229
Draft
Reenable JRuby #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
reenable_jruby
branch
from
f9b5e2a to
b952747
Compare
|
This will need to be re-run after "jruby-head" builds get published overnight tonight or tomorrow. |
|
I did not exclude Windows for now because I don't know why it wouldn't pass. If it fails again I'll look into it or exclude it again. |
|
The JRuby 9.4.9.0 jobs are failing due to the version conflict. The head builds should be ok, but we may want to just remove the non-head jobs until I can figure out a workaround for the jar-dependencies conflict issue (or until JRuby 9.4.10.0 ships with a fix for it). |
headius
added a commit
to headius/jruby
that referenced
this pull request
Dec 10, 2024
By requiring a file from jar-dependencies here, we end up activating whatever the default jar-dependencies gem is for the current JRuby runtime. Later on, when the hook is running or gems that use jars simply try to activate a newer jar-dependencies, we get the dreaded version conflict described in mkristian/jar-dependencies#86, preventing activation of all libraries. The change here moves the body of the hook into the JRuby defaults.rb for RubyGems rather than loading any files from jar-dependencies itself. This appears to fix issues like those seen in the jruby-9.4.9.0 builds at ruby/rdoc#1229 (bundle exec failing to run due to the version conflict) and may fix other reports. This does not fix issues using a newer jar-dependencies on an older JRuby, unfortunately.
This was referenced Dec 10, 2024
|
Marked as draft until we can confirm it with patched JRuby builds. |
|
Well, the jruby-head builds have started to pass, but only on macos so far. Continuing to investigate remaining issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1228