Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated upstart_triplet in graph_stores_neptune to better deal with i… #17363

Conversation

Riddhimaan-Senapati
Copy link
Contributor

@Riddhimaan-Senapati Riddhimaan-Senapati commented Dec 24, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

The goal of this PR is to fix issue 17358, implementing the solution suggested there with sanitising the inputs for upstart_triplet in graph_stores_neptune. No dependencies need to be updated for this to work.

Fixes #17358

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

There is no new package

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Not required due to simple bug fix.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas(minor change made to a function)
  • I have made corresponding changes to the documentation.(Not required)
  • I have added Google Colab support for the newly added notebooks.(Not needed, changed a .py file)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works.(Covered by existing tests, simply sanitizes some inputs)
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

…ssue 17358, implementing the solution suggested there.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 24, 2024
@Riddhimaan-Senapati
Copy link
Contributor Author

@logan-markewich Can you review my PR. I can't test it since I don't have an api key but hopefully this should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid label generated for upsert_triplet method when creating a KG for Neptune Analytics
1 participant