Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword prec for exponential and logarithm of Drinfeld modules #39214

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Dec 28, 2024

Currently, the methods exponential and logarithm for Drinfeld modules return a LazyPowerSeriesRing for which not all methods are available.
We add a keyword prec. When it is Infinity (which is the default), the behavior is unchanged. However, when we pass in a finite number, a classical power series (up to the given precision) is returned.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

Documentation preview for this PR (built with commit 174d4a4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mantepse
Copy link
Collaborator

Off topic: Which methods are missing in LazyPowerSeries?

@xcaruso
Copy link
Contributor Author

xcaruso commented Dec 28, 2024

e.g. sqrt (it is implemented only for series congruent to 1 modulo x), nth_root, continued_fraction...
Also printing more terms is a little bit tricky; we need to set the parameter parent.options.display_length (which moreover is global, we cannot easily change this for just one shot).

@mantepse
Copy link
Collaborator

e.g. sqrt (it is implemented only for series congruent to 1 modulo x), nth_root,

Oh, I missed the possibility of taking out x^n!

continued_fraction...

I actually have code for that, but was too lazy to get it in.

Also printing more terms is a little bit tricky; we need to set the parameter parent.options.display_length (which moreover is global, we cannot easily change this for just one shot).

I agree. Maybe we can discuss this at sd128?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants