Integrated changes from the pb2b angle solution pipeline to handle glitches better #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykyohei
reviewed
Oct 30, 2024
ykyohei
requested changes
Nov 25, 2024
…glitched references
ykyohei
reviewed
Dec 28, 2024
Comment on lines
+1538
to
+1540
| if not result: | ||
| mask = np.full(len(diff), False) | ||
| dead_rots.append(i) |
There was a problem hiding this comment.
I finished testing this on all the observations. This is working for most of the observations, but I found some edge cases where this PR performs worse than before. I listed up the obs_ids as follows.
In these obs_ids, I think the glitch removal is failed, and the removal of failed rotation is leading to larger glitch. Could you take a look at these obs_ids? @bbixler500
obs_1714436045_satp1_1111101
obs_1714439875_satp1_1111101
obs_1714443842_satp1_1111101
obs_1714451357_satp1_1111101
obs_1714462951_satp1_1111101
obs_1714470498_satp1_1111101
obs_1714474327_satp1_1111101
obs_1714948989_satp1_1111011
obs_1714979726_satp1_1111011
obs_1731357259_satp1_1111111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes to the angle solution pipeline which should implement the pb2b glitch finding algorithm. I have tested only the
analyzemethod and only on the datasetobs_1713734012_satp1_00010000. On that dataset the algorithm correctly cleans the glitches from the angle solution. More testing on other datasets is needed.