G3thk trim #883
Open
G3thk trim #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates g3thk to only query fields for agents from the site-pipeline configs; i.e., pysmurf monitor and supersync to aid the data packaging tools from the level2 side, and there fore reduce g3thk db size
… in the config file
|
marking it ready for review as we confirmed that nothing's really needed for level 2 site hk data for data packaging |
kmharrington
reviewed
Aug 7, 2024
| self.engine = db.create_engine(f"sqlite:///{db_path}", echo=echo) | ||
| Session.configure(bind=self.engine) | ||
| self.Session = sessionmaker(bind=self.engine) | ||
| self.session = Session() | ||
| Base.metadata.create_all(self.engine) | ||
|
|
||
| def load_fields(self, hk_path): | ||
|
|
||
| def load_fields(self, hk_path, iids): |
There was a problem hiding this comment.
why do we need to pass iids if those are already saved in self?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for using the g3tsmurf_hwp_config.yaml file to obtain agent instance IDs for populating the Level 2 g3thk database for data packaging.
This will work for lat, satp1, satp2, satp3 g3thk level 2 databases. Was pointed to a site pipeline config file that uses the site g3thk database, but haven't yet looked into what is necessary for level 2 site g3thk database. Hence, the draft PR.