Add Filter Object to Multi Conversation Select Block Element #1191
Conversation
block_element.go
Outdated
| @@ -279,6 +279,7 @@ type MultiSelectBlockElement struct { | |||
| InitialChannels []string `json:"initial_channels,omitempty"` | |||
| MinQueryLength *int `json:"min_query_length,omitempty"` | |||
| MaxSelectedItems *int `json:"max_selected_items,omitempty"` | |||
| Filter *SelectBlockElementFilter `json:"filter,omitempty"` | |||
There was a problem hiding this comment.
[nits]
We should rename to ConversationListsFilter.
There was a problem hiding this comment.
Hi @kanata2 i've updated to be ConversationListsFilter, kindly help to check again :)
There was a problem hiding this comment.
(Sorry, this suggestion is backward imcompatible change... I'll make new minor version and include this.)
There was a problem hiding this comment.
Btw is there anything that i need to do ? or just waiting for this MR merged by you? @kanata2
There was a problem hiding this comment.
I'll merge and release as soon as it's ready.
There was a problem hiding this comment.
Sorry, this was a mis-communication; it should be Filter -> ConversationListFilter. We definitely don't want to rename the existing SelectBlockElementFilter. If you want to correct this and the linting issues I'll have another look.
PR preparation
make pr-prepfrom the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
N/A
This changes is to add the
filterobject inmulti_conversation_selectblock element type since the documentation said thefilterobject is also supported in that type. Currently thefilterobject only present inconversation_selecttype.Reference to the documentation: