Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle network change for filter subs #21863

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chaitanyaprem
Copy link
Contributor

If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number

otherwise

fixes #...

Summary

...

Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx

Review notes

Testing notes

Platforms

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes
Non-functional
  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test

  • Open Status
  • ...
  • Step 3, etc.

Before and after screenshots comparison

Figma (if available) iOS (if available) Android (if available)
Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Dec 23, 2024

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4320b8f #1 2024-12-23 10:05:35 ~5 min tests 📄log
✔️ 4320b8f #1 2024-12-23 10:08:44 ~8 min ios 📱ipa 📲
✔️ 4320b8f #1 2024-12-23 10:09:32 ~9 min android-e2e 🤖apk 📲
✔️ 4320b8f #1 2024-12-23 10:10:59 ~10 min android 🤖apk 📲
✔️ afb6c14 #3 2024-12-24 05:34:59 ~5 min tests 📄log
✔️ afb6c14 #3 2024-12-24 05:36:53 ~7 min android-e2e 🤖apk 📲
✔️ afb6c14 #3 2024-12-24 05:38:39 ~9 min ios 📱ipa 📲
✔️ afb6c14 #3 2024-12-24 05:39:48 ~10 min android 🤖apk 📲
40a42d2 #4 2024-12-24 09:00:42 ~2 min android 📄log
40a42d2 #4 2024-12-24 09:00:43 ~2 min android-e2e 📄log
40a42d2 #4 2024-12-24 09:01:14 ~2 min tests 📄log
40a42d2 #4 2024-12-24 09:01:55 ~3 min ios 📄log
✔️ 3a2cfa3 #5 2024-12-24 09:14:53 ~5 min tests 📄log
✔️ 3a2cfa3 #5 2024-12-24 09:18:32 ~8 min android-e2e 🤖apk 📲
✔️ 3a2cfa3 #5 2024-12-24 09:19:52 ~10 min ios 📱ipa 📲
✔️ 3a2cfa3 #5 2024-12-24 09:19:53 ~10 min android 🤖apk 📲
✔️ 6a1ccbb #6 2024-12-24 09:45:27 ~4 min tests 📄log
✔️ 6a1ccbb #6 2024-12-24 09:49:02 ~8 min android-e2e 🤖apk 📲
✔️ 6a1ccbb #6 2024-12-24 09:50:24 ~9 min ios 📱ipa 📲
✔️ 6a1ccbb #6 2024-12-24 09:50:33 ~10 min android 🤖apk 📲
✔️ c896820 #8 2024-12-25 05:39:14 ~4 min tests 📄log
✔️ c896820 #8 2024-12-25 05:42:57 ~8 min android-e2e 🤖apk 📲
✔️ c896820 #8 2024-12-25 05:43:33 ~8 min ios 📱ipa 📲
✔️ c896820 #8 2024-12-25 05:43:37 ~8 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c328767 #9 2024-12-25 07:54:42 ~4 min tests 📄log
✔️ c328767 #9 2024-12-25 07:58:35 ~8 min android-e2e 🤖apk 📲
✔️ c328767 #9 2024-12-25 07:59:57 ~10 min ios 📱ipa 📲
✔️ c328767 #9 2024-12-25 07:59:58 ~10 min android 🤖apk 📲
✔️ 67184f6 #10 2024-12-27 04:12:10 ~5 min tests 📄log
✔️ 67184f6 #10 2024-12-27 04:14:01 ~7 min android-e2e 🤖apk 📲
✔️ 67184f6 #10 2024-12-27 04:16:03 ~9 min ios 📱ipa 📲
✔️ 67184f6 #10 2024-12-27 04:16:40 ~10 min android 🤖apk 📲

@chaitanyaprem chaitanyaprem force-pushed the fix/filter-network-change branch 8 times, most recently from c896820 to c328767 Compare December 25, 2024 07:49
@chaitanyaprem chaitanyaprem force-pushed the fix/filter-network-change branch from c328767 to 67184f6 Compare December 27, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: CONTRIBUTOR
Development

Successfully merging this pull request may close these issues.

2 participants