Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21853] fix: check deeplink pending request after wallet connect loaded #21873

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Dec 27, 2024

fixes #21853

Summary

  • "cannot read property" error is displayed on profiles list page
  • Handle pending dapp pair request after wallet connect loaded successfully

Areas that maybe impacted

  • Dapps interactions

Test Note

Regarding the issue discussed in PR #21833, here’s an explanation of how dApp requests are handled and the current limitations:

Handling dApp Requests

  1. Event Listener

    • The app registers an event listener to handle incoming dApp requests.
    • However, this listener is only registered after the wallet screen loads. If a request is sent before the listener is active, it will not be processed.
  2. Deep Link

    • Currently, pairing requests from a dApp can be handled through deep links, where the dApp sends a URI containing the pairing information to the app.
    • However, sign requests are not handled through deep links. This means any signing request (e.g., transactions or message signing) that is initiated via deep link will not work if user is not logged in already.
    • If the app is launched through a deep link for a pairing request, the process works as expected, as shown in the video below.
  3. Push Notification (Not Yet Implemented)

    • Push notifications are intended to handle scenarios where the app is closed, and the request is sent to a different device.
    • The issue in PR #21833 highlights this limitation. Currently, push notifications are not supported for any type of request.

for PR #21833 we can have a separate issue so i can discuss it with @clauxx and check for any solution.

Steps to test

  1. Connect to the Dapp(in my case Uniswap) using universal scanner
  2. Log out
  3. Make any transaction Using Dapp (approve or swap)

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-12-27.at.17.11.05.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Dec 27, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 27, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f5ae111 #1 2024-12-27 13:00:17 ~4 min tests 📄log
✔️ f5ae111 #1 2024-12-27 13:02:48 ~6 min android-e2e 🤖apk 📲
✔️ f5ae111 #1 2024-12-27 13:03:19 ~7 min ios 📱ipa 📲
✔️ f5ae111 #1 2024-12-27 13:03:23 ~7 min android 🤖apk 📲

@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review December 27, 2024 14:17
@mohsen-ghafouri mohsen-ghafouri requested review from alwx, smohamedjavid and vkjr and removed request for alwx December 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

"cannot read property" error is displayed on profiles list page when the Dapp attempts to send a signature
2 participants