Call stack perf change for CallerInfo #1614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Jun 24, 2024
ccoVeille
approved these changes
Jun 25, 2024
brackendawson
requested changes
Nov 23, 2024
assert/assertions.go
Outdated
Comment on lines
277
to
290
| if more { | ||
| continue | ||
| } | ||
| // We know we already have less than a buffer's worth of frames | ||
| if !maybeMore { | ||
| break | ||
| } | ||
| offset += stackFrameBufferSize | ||
| n = runtime.Callers(offset, pcs) | ||
| if n == 0 { | ||
| break | ||
| } | ||
|
|
||
| maybeMore = n == stackFrameBufferSize |
There was a problem hiding this comment.
Copying this comment from #1615 which also contains this change.
I'm not a fan of more and maybeMore, this code is actually two nested loops and I think it would be more readable if you coded it that way. I think that pure behaviour is usually better than data (varibles) used only to alter behaviour.
There was a problem hiding this comment.
I just pushed a commit that moves this to two loops (though still using more to break out of the inner loop). LMK if that's along the lines of what you were thinking.
|
The performance enhancement in this code is a change I'd be happy to include, with some slight alteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CallerInfoto useruntime.Callers()to pull the stack instead of repeatedly callingruntime.Caller()Changes
Callers()instead of repeatedCallerinvocations, because there is a cost to querying the stackframes.Next()iteratorMotivation
Callercontributing a CPU cost of 7660ms out of a total cost of 13740msRelated issues