fix: Finding main view controller on iOS #1736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a situation when `rootViewController` is not set by the application, the main view controller is not found, resulting in error: Attempt to present <STP_Internal_BottomSheetViewController> on <UIViewController> (from <UIViewController>) whose view is not in the window hierarchy. which then prevents the Stripe bottom sheet from showing. Blocking the payment flow. To prevent this, a fallback is added to traverse the windows hierarchy and find the first one that has `isKeyWindow` set to `true`. Co-authored-by: Bruno Pastre <[email protected]>
dluksza
requested review from
charliecruzan-stripe and
a team
as code owners
|
|
jonasbark
approved these changes
Sep 20, 2024
|
Very good catch @dluksza, hopefully we can go back to a release version of stripe before we launch the marketplace for OneFootball and 11TeamSports end of next month. |
|
hey @charliecruzan-stripe, what are we missing to get this in? Sorry to bother, but we're happy to make any changes requested and go back to use Stripe from trunk :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a situation when
rootViewControlleris not set by the application, the main view controller is not found, resulting in error:Attempt to present <STP_Internal_BottomSheetViewController> on (from ) whose view is not in the window hierarchy.
which then prevents the Stripe bottom sheet from showing. Blocking the payment flow.
To prevent this, a fallback is added to traverse the windows hierarchy and find the first one that has
isKeyWindowset totrue.Testing
Documentation
Select one: