Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float Donation Button to Enhance Banner Visibility #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Devmoni
Copy link
Contributor

@Devmoni Devmoni commented Dec 26, 2024

Description

A floating button for the donation banner to ensure visibility when the current banner is not visible or partially obscured.

Purpose

SugarLabs aims to raise $25K by this fall, and the current donation banner is visually effective. However, if a user closes the banner or scrolls down, the banner becomes hidden. This is particularly noticeable on mobile devices, where the site's "Donate" button is located within the hamburger menu, making it less accessible.

To address this, I have implemented a floating donation button. This button becomes visible when the user scrolls down and the current banner is no longer in view or when the user closes the banner. It ensures a persistent and accessible way to encourage donations at all times.

Screenshot

image

@quozl
Copy link
Contributor

quozl commented Dec 26, 2024

Reviewed. Does seem a lot of complexity for something so simple, but I guess we'll always have a donate button.

Acceptable commit message, as if you lacked the time to write anything better, but then you go and write a huge pull request opening comment; much of that text really should be in the commit message.

@quozl quozl mentioned this pull request Dec 26, 2024
- Adds a floating donation button to maintain visibility when the main banner is not in view.
- Appears when users scroll down or close the banner.
@Devmoni
Copy link
Contributor Author

Devmoni commented Dec 27, 2024

Hopefully, the new commit message meets the expectations :)

@quozl
Copy link
Contributor

quozl commented Dec 28, 2024

Yes, thanks.

@quozl quozl requested a review from pikurasa December 28, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants