Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import defer tests for evaluation triggers #4341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nicolo-ribaudo
Copy link
Member

Ref #4215.

This updates the tests that check what operations trigger evaluation of deferred modules, based on consensus in the last TC39 meeting. It's effectively what is included in tc39/proposal-defer-import-eval#53.

This PR doesn't include tests about what the results of those operations are (which will need to be tested for .then).

I suggest reviewing commit-by-commit:

  • first the first one
  • then the last one
  • then the second one
  • then the third one

All the tests are auto-generated from templates.

There is a bug with templates btw: their desc cannot start with [, because the generator will not escape/prefix it and so it becomes a Yaml array. I had to prefix all the descs with _ for this reason.

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner December 12, 2024 15:37
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Dec 12, 2024
38 tasks
@nicolo-ribaudo nicolo-ribaudo changed the title Remove old tests about import defer evaluation triggers Update import defer tests for evaluation triggers Dec 12, 2024
@takikawa
Copy link
Contributor

I tried running this in my webkit prototype that's been updated to the new semantics, and as far as I can tell the test cases all run and agree with the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants