Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the phase in tests about invalid JSON module bindings #4348

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 13, 2024

These errors don't happen when parsing the file, but when linking it with its dependencies.

Fixes half of #4124

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner December 13, 2024 11:03
@Ms2ger Ms2ger enabled auto-merge (squash) December 17, 2024 14:55
@Ms2ger Ms2ger merged commit 36687a5 into tc39:main Dec 17, 2024
11 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the phase-json branch December 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants