Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused code: CacheAwareFunctionWrapper #1121

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Delete unused code: CacheAwareFunctionWrapper #1121

merged 1 commit into from
Dec 18, 2024

Conversation

eabatalov
Copy link
Contributor

There no known roadmap items to implement local caching for local graph executions. So let's delete this code.

Testing:

make check
make test

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • [n/a] If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@eabatalov
Delete unused code: CacheAwareFunctionWrapper
736055d 
There no known roadmap items to implement local caching for
local graph executions. So let's delete this code.

Testing:

make check
make test
@eabatalov eabatalov marked this pull request as ready for review December 18, 2024 17:03
@eabatalov eabatalov merged commit ee0afc6 into main Dec 18, 2024
8 checks passed
@eabatalov eabatalov deleted the eugene-delete-CacheAwareFunctionWrapper branch December 18, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eabatalov